Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge 18 supports 'finally' #3013

Merged
merged 2 commits into from Oct 25, 2018
Merged

Edge 18 supports 'finally' #3013

merged 2 commits into from Oct 25, 2018

Conversation

Barbiero
Copy link
Contributor

I just tried it out on Edge v44.17763:

<< new Promise((res, rej) => res(2)).then(console.debug).finally(() => console.debug('finalized'))
>> [object Promise]: {}
>> 2
>> finalized

I haven't tested it on edge mobile. Also, if anyone could test it on earlier versions of Edge to figure out when support was added, it'd be appreciated.

@Elchi3 Elchi3 added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Oct 25, 2018
@Elchi3
Copy link
Member

Elchi3 commented Oct 25, 2018

HI there, thanks for contributing to mdn-browser-compat-data! 👍

Edge doesn't come with a version 44. Maybe some internal engines are versioned like that, but Microsoft decided to go with release versions for this compat data set. So, maybe this is version 17 or 18 or so?

The official status is still "in development" so, I'm not sure about whether it's supported or not. https://developer.microsoft.com/en-us/microsoft-edge/platform/status/promiseprototypefinally/

@saschanaz
Copy link
Contributor

Edge has two independent versions: app and engine. 44 is the former, 18 is the latter.

@Elchi3
Copy link
Member

Elchi3 commented Oct 25, 2018

Changed this to 18, kangax agrees with version 18, so Edge's platform status is likely out of date.

Elchi3
Elchi3 approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and welcome to mdn-browser-compat-data! 👍 :tada

@Elchi3 Elchi3 merged commit 35a8dee into mdn:master Oct 25, 2018
@Elchi3 Elchi3 changed the title Edge v44 supports 'finally' Edge 18 supports 'finally' Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Barbiero @Elchi3 @saschanaz